[v3-1-test] Replace defaultValue with value in TaskTrySelect (#56141) #56258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <[email protected]>
1 task
pierrejeambrun
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
bbovenzi
approved these changes
Sep 30, 2025
jscheffl
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.
Applied prop ordering fix as requested in code review.
Props are now alphabetically ordered in the Select.Root component.
(cherry picked from commit 3f7991f)
Co-authored-by: Vedant Mamgain [email protected]