Skip to content

Conversation

@ayush3singh
Copy link
Contributor

@ayush3singh ayush3singh commented May 17, 2025

Fixes #50386

As part of Airflow 2 to 3 migration we noticed dag_run.json became a JSON field. Since we don't need this in non-production we deleted the column and added new one with JSON type which is nullable as per the migration. But it's not nullable in the pydantic definition thus causing API error when a dagrun with null conf is present.

This PR changed schema conf as nullable and generated files for the change

@boring-cyborg boring-cyborg bot added area:airflow-ctl area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels May 17, 2025
@ayush3singh ayush3singh marked this pull request as ready for review May 17, 2025 18:55
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Rebase needed due to some CI faluire and for a clean history :)

@ayush3singh
Copy link
Contributor Author

@bugraoz93
Thanks for the review :)
Have updated the branch.

@bbovenzi bbovenzi added this to the Airflow 3.0.2 milestone May 19, 2025
@bbovenzi bbovenzi changed the title make dag_run null able in Details page Make dag_run.conf nullable in Details page May 19, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label May 20, 2025
@pierrejeambrun pierrejeambrun merged commit e6282e0 into apache:main May 20, 2025
96 checks passed
github-actions bot pushed a commit that referenced this pull request May 20, 2025
(cherry picked from commit e6282e0)

Co-authored-by: ayush3singh <[email protected]>
@github-actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

potiuk pushed a commit that referenced this pull request May 21, 2025
(cherry picked from commit e6282e0)

Co-authored-by: ayush3singh <[email protected]>
pierrejeambrun pushed a commit that referenced this pull request May 21, 2025
(cherry picked from commit e6282e0)

Co-authored-by: ayush3singh <[email protected]>
potiuk pushed a commit that referenced this pull request May 21, 2025
(cherry picked from commit e6282e0)

Co-authored-by: ayush3singh <[email protected]>
potiuk pushed a commit that referenced this pull request May 21, 2025
dadonnelly316 pushed a commit to dadonnelly316/airflow that referenced this pull request May 26, 2025
kaxil pushed a commit that referenced this pull request Jun 3, 2025
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:airflow-ctl area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dag_run.conf should be nullable in API as per the database schema

4 participants