Skip to content

Conversation

@AshwinSekar
Copy link
Contributor

@AshwinSekar AshwinSekar commented Mar 2, 2025

chido is working on getting buildkite to recognize the PAT

@AshwinSekar AshwinSekar requested review from carllin and yihau March 3, 2025 03:44
@@ -1,4 +1,6 @@
name: Cargo
with:
token: ${{ secrets.AG_PAT }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihau i've added the PAT as a secret to this repo, but not sure how we can put it into the buildkite agent so they can ssh for the dependency:

alpenglow-vote = { git = "ssh://[email protected]/solana-program/alpenglow-vote.git", rev = "8942fe9" }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent some time understanding the real issue. it's a long story. tldr, I will need some time to update the Buildkite agent part and will provide an update here.
btw, we can remove .github/* modification in this PR. we don't run Github Actions in this repo.

Copy link
Member

@yihau yihau Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use this patch as a workaround: 1390cc6

@AshwinSekar AshwinSekar requested a review from wen-coding March 3, 2025 03:46
}
}

pub struct EtcdVoteHistoryStorage {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carllin removed this guy while i was here since it's no longer supported and planned for removal in 3.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, kill it all

@AshwinSekar AshwinSekar merged commit 026e17a into anza-xyz:master Mar 5, 2025
7 checks passed
@AshwinSekar AshwinSekar deleted the integrate-aspenglow-vote branch March 5, 2025 21:04
carllin pushed a commit that referenced this pull request Mar 13, 2025
@AshwinSekar AshwinSekar mentioned this pull request Mar 13, 2025
Closed
carllin pushed a commit that referenced this pull request Mar 13, 2025
carllin pushed a commit that referenced this pull request Mar 13, 2025
bw-solana pushed a commit to bw-solana/alpenglow that referenced this pull request Aug 1, 2025
bw-solana pushed a commit to bw-solana/alpenglow that referenced this pull request Aug 1, 2025
bw-solana pushed a commit to bw-solana/alpenglow that referenced this pull request Aug 1, 2025
bw-solana pushed a commit to bw-solana/alpenglow that referenced this pull request Aug 1, 2025
bw-solana pushed a commit to bw-solana/alpenglow that referenced this pull request Aug 1, 2025
bw-solana pushed a commit to bw-solana/alpenglow that referenced this pull request Aug 1, 2025
bw-solana pushed a commit to bw-solana/alpenglow that referenced this pull request Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants