-
Notifications
You must be signed in to change notification settings - Fork 33
integrate aspenglow vote program #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate aspenglow vote program #63
Conversation
.github/workflows/cargo.yml
Outdated
| @@ -1,4 +1,6 @@ | |||
| name: Cargo | |||
| with: | |||
| token: ${{ secrets.AG_PAT }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yihau i've added the PAT as a secret to this repo, but not sure how we can put it into the buildkite agent so they can ssh for the dependency:
alpenglow-vote = { git = "ssh://[email protected]/solana-program/alpenglow-vote.git", rev = "8942fe9" }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent some time understanding the real issue. it's a long story. tldr, I will need some time to update the Buildkite agent part and will provide an update here.
btw, we can remove .github/* modification in this PR. we don't run Github Actions in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use this patch as a workaround: 1390cc6
| } | ||
| } | ||
|
|
||
| pub struct EtcdVoteHistoryStorage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carllin removed this guy while i was here since it's no longer supported and planned for removal in 3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing, kill it all
chido is working on getting buildkite to recognize the PAT