PohService needs to set use_alpenglow_tick_producer flag on startup
#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wen-coding
reviewed
Feb 28, 2025
| if !poh_exit.load(Ordering::Relaxed) | ||
| // Should be set by replay_stage after it sees a notarized | ||
| // block in the new alpenglow epoch | ||
| && poh_recorder.read().unwrap().is_alpenglow_enabled |
Contributor
There was a problem hiding this comment.
Do you still need this test? Maybe just say the only way it exits the previous loop is either:
- poh_exit is true
- alpenglow is enabled
So only exit the loop if 1 is true.
Then you can move the info loop to line 169~175?
Contributor
Author
There was a problem hiding this comment.
The info log is only necessary if we started in not alpenglow mode, and then migrated to alpenglow. If we started in alpenglow mode, there's no need to print that we're migrating
Contributor
There was a problem hiding this comment.
Hmm ok, we can also do:
if poh_exit.load(Ordering::Relaxed) {
return;
} else { // must exit because of Alpenglow
info(...)
}
Your choice.
Contributor
Author
There was a problem hiding this comment.
hmm actually I might like the original better, I want to explicitly check that alpenglow was enabled in case somebody else adds another path/error on which poh would exit
wen-coding
approved these changes
Feb 28, 2025
| if !poh_exit.load(Ordering::Relaxed) | ||
| // Should be set by replay_stage after it sees a notarized | ||
| // block in the new alpenglow epoch | ||
| && poh_recorder.read().unwrap().is_alpenglow_enabled |
carllin
added a commit
that referenced
this pull request
Mar 1, 2025
PohService needs to set `use_alpenglow_tick_producer` flag on startup (#59)
carllin
added a commit
that referenced
this pull request
Mar 1, 2025
PohService needs to set `use_alpenglow_tick_producer` flag on startup (#59)
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
PohService needs to set `use_alpenglow_tick_producer` flag on startup (anza-xyz#59)
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
PohService needs to set `use_alpenglow_tick_producer` flag on startup (anza-xyz#59)
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
PohService needs to set `use_alpenglow_tick_producer` flag on startup (anza-xyz#59)
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
PohService needs to set `use_alpenglow_tick_producer` flag on startup (anza-xyz#59)
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
PohService needs to set `use_alpenglow_tick_producer` flag on startup (anza-xyz#59)
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
PohService needs to set `use_alpenglow_tick_producer` flag on startup (anza-xyz#59)
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 2, 2025
PohService needs to set `use_alpenglow_tick_producer` flag on startup (anza-xyz#59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
flag
use_alpenglow_tick_produceris not enabled at startupSummary of Changes
Fixes #