-
Notifications
You must be signed in to change notification settings - Fork 33
test(local-cluster): liveness after intertwined skip-fallback and notar-fallback #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ksn6
merged 7 commits into
anza-xyz:master
from
ksn6:local-cluster-ensure-liveness-after-skip-fallback
Jul 24, 2025
Merged
test(local-cluster): liveness after intertwined skip-fallback and notar-fallback #235
ksn6
merged 7 commits into
anza-xyz:master
from
ksn6:local-cluster-ensure-liveness-after-skip-fallback
Jul 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
reviewed
Jul 3, 2025
bw-solana
reviewed
Jul 3, 2025
Contributor
bw-solana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great test with awesome documentation. Thank you!
Left a handful of nits and a couple suggestions
2b53e68 to
4324b7d
Compare
bw-solana
approved these changes
Jul 6, 2025
Contributor
bw-solana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d78291c to
0e1cbec
Compare
2222568 to
51576b5
Compare
4b5f1c7 to
a6039bc
Compare
wen-coding
reviewed
Jul 23, 2025
wen-coding
approved these changes
Jul 24, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Test to validate Alpenglow's ability to maintain liveness when nodes issue both NotarizeFallback and SkipFallback votes in an intertwined manner.
This test simulates a consensus scenario with four nodes having specific stake distributions:
The test proceeds through two main stages:
Stage 1: Stable Network Operation
All nodes are voting normally for leader D's proposals, with notarization votes going through successfully and the network maintaining consensus.
Stage 2: Network Partition and Fallback Scenario
At slot 50, Node A's turbine is disabled, creating a network partition. This triggers the following sequence:
The test validates that: