bpf_loader: Apply debug port offset with regards to the CPI level to prevent port collisions #9317
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fset with regards to the CPI level to avoid port collisions. The reason for this is that when debugging a CPI it needs another debug port to listen on as it takes place in the middle of the ongoing TCP debugging session.
|
The Firedancer team maintains a line-for-line reimplementation of the |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently on each program execution the SBPF debugger starts listening on $VM_DEBUG_PORT.
This is particularly a problem when there are CPIs as on each CPI another VM is instantiated attempting to reuse $VM_DEBUG_PORT.
Summary of Changes
The VM's debug port is added an offset with regards to the CPI level to avoid port collisions.
This PR wraps up everything explained here anza-xyz/sbpf#79 but I believe with a simpler and cleaner implementation.