fix(deps): update module github.com/stretchr/testify to v1.11.1 (main) #7448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
added
dependencies
renovate
bot
changed the title
renovate
bot
changed the title
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate
bot
force-pushed
the
renovate/main-github.zerozr99.workers.dev-stretchr-testify-1.x
branch
from
3a3b007 to
64994d5
Compare
Contributor
|
/test-all |
Contributor
|
Some test failures that I need to resolve manually. I had the same issue with vmware/go-ipfix. |
The tests were not correct to begin with, and a change in the `assert.Eventually` implementation exposed the bug: stretchr/testify#1427 Signed-off-by: Antonin Bas <[email protected]>
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Contributor
|
@luolanzone some manual fixes were required as 2 unit tests started failing after the dependency upgrade (because of this change: stretchr/testify#1427). PTAL. |
luolanzone
approved these changes
Sep 23, 2025
Contributor
|
/test-all |
antoninbas
deleted the
renovate/main-github.zerozr99.workers.dev-stretchr-testify-1.x
branch
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Sep 23, 2025
This is a follow-up to antrea-io#7448. The change in behavor of assert.Eventually has caused to the unit test to become flaky. This change improves how the result of egress selection is validated, and resolves the flakiness issue. It is expected that the test function can be greatly improved when we upgrade to Go 1.25 and we can start using the new testing/synctest package. Upgrading to Go 1.25 is not immediately possible because of some dependency issues. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Sep 23, 2025
This is a follow-up to antrea-io#7448. The change in behavor of assert.Eventually has caused to the unit test to become flaky. This change improves how the result of egress selection is validated, and resolves the flakiness issue. It is expected that the test function can be greatly improved when we upgrade to Go 1.25 and we can start using the new testing/synctest package. Upgrading to Go 1.25 is not immediately possible because of some dependency issues. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Sep 24, 2025
The test had an invalid usage of assert.EventuallyWithT: the assertions included in the condition function applied to the outer *testing.T instead of to the condition function parameter. After antrea-io#7448, the test started failing due to the change in the implementation of assert.EventuallyWithT. Signed-off-by: Antonin Bas <[email protected]>
luolanzone
pushed a commit
that referenced
this pull request
Sep 24, 2025
The test had an invalid usage of assert.EventuallyWithT: the assertions included in the condition function applied to the outer *testing.T instead of to the condition function parameter. After #7448, the test started failing due to the change in the implementation of assert.EventuallyWithT. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Oct 6, 2025
This is a follow-up to #7448. The change in behavor of assert.Eventually has caused to the unit test to become flaky. This change improves how the result of egress selection is validated, and resolves the flakiness issue. It is expected that the test function can be greatly improved when we upgrade to Go 1.25 and we can start using the new testing/synctest package. Upgrading to Go 1.25 is not immediately possible because of some dependency issues. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.
This PR contains the following updates:
v1.10.0->v1.11.1Release Notes
stretchr/testify (github.com/stretchr/testify)
v1.11.1Compare Source
This release fixes #1785 introduced in v1.11.0 where expected argument values implementing the stringer interface (
String() string) with a method which mutates their value, when passed to mock.Mock.On (m.On("Method", <expected>).Return()) or actual argument values passed to mock.Mock.Called may no longer match one another where they previously did match. The behaviour prior to v1.11.0 where the stringer is always called is restored. Future testify releases may not call the stringer method at all in this case.What's Changed
Full Changelog: stretchr/testify@v1.11.0...v1.11.1
v1.11.0Compare Source
What's Changed
Functional Changes
v1.11.0 Includes a number of performance improvements.
Fixes
Documentation, Build & CI
New Contributors
Full Changelog: stretchr/testify@v1.10.0...v1.11.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.