fix: add missing f-string prefix in async_to_httpx_files error message#1481
Closed
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Closed
fix: add missing f-string prefix in async_to_httpx_files error message#1481xodn348 wants to merge 1 commit intoanthropics:mainfrom
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Conversation
The TypeError in async_to_httpx_files() was missing the f-string prefix,
causing the error message to literally print '{type(files)}' instead of
the actual type. The sync counterpart to_httpx_files() already had the
correct f-string. Added tests for both sync and async error messages.
Collaborator
|
Thanks for the PR! I've fixed it in our codegen, see commit (06d109a) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
TypeErrorraised inasync_to_httpx_files()was missing thefprefix on its format string, causing the error message to literally print{type(files)}instead of the actual type. The sync counterpartto_httpx_files()already had the correct f-string (line 60).Before (line 102):
After:
Verification