Skip to content

Commit 143efcc

Browse files
chore(internal): make test_proxy_environment_variables more resilient to env
1 parent 1009d4a commit 143efcc

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

tests/test_client.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1045,8 +1045,14 @@ def retry_handler(_request: httpx.Request) -> httpx.Response:
10451045
def test_proxy_environment_variables(self, monkeypatch: pytest.MonkeyPatch) -> None:
10461046
# Test that the proxy environment variables are set correctly
10471047
monkeypatch.setenv("HTTPS_PROXY", "https://example.org")
1048-
# Delete in case our environment has this set
1048+
# Delete in case our environment has any proxy env vars set
10491049
monkeypatch.delenv("HTTP_PROXY", raising=False)
1050+
monkeypatch.delenv("ALL_PROXY", raising=False)
1051+
monkeypatch.delenv("NO_PROXY", raising=False)
1052+
monkeypatch.delenv("http_proxy", raising=False)
1053+
monkeypatch.delenv("https_proxy", raising=False)
1054+
monkeypatch.delenv("all_proxy", raising=False)
1055+
monkeypatch.delenv("no_proxy", raising=False)
10501056

10511057
client = DefaultHttpxClient()
10521058

@@ -2050,8 +2056,14 @@ async def test_get_platform(self) -> None:
20502056
async def test_proxy_environment_variables(self, monkeypatch: pytest.MonkeyPatch) -> None:
20512057
# Test that the proxy environment variables are set correctly
20522058
monkeypatch.setenv("HTTPS_PROXY", "https://example.org")
2053-
# Delete in case our environment has this set
2059+
# Delete in case our environment has any proxy env vars set
20542060
monkeypatch.delenv("HTTP_PROXY", raising=False)
2061+
monkeypatch.delenv("ALL_PROXY", raising=False)
2062+
monkeypatch.delenv("NO_PROXY", raising=False)
2063+
monkeypatch.delenv("http_proxy", raising=False)
2064+
monkeypatch.delenv("https_proxy", raising=False)
2065+
monkeypatch.delenv("all_proxy", raising=False)
2066+
monkeypatch.delenv("no_proxy", raising=False)
20552067

20562068
client = DefaultAsyncHttpxClient()
20572069

0 commit comments

Comments
 (0)