feat: add STATUS enum for MAPDL state management#4221
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a STATUS enum to replace string literals for MAPDL state management, improving type safety and code maintainability. The changes move from magic strings like "exited", "exiting", and "OK" to well-defined enum values.
- Adds a STATUS enum with EXITED, EXITING, and RUNNING values
- Updates the check_status property to use enum values instead of strings
- Improves type annotation by specifying STATUS as the return type
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…-enums-for-status
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4221 +/- ##
==========================================
- Coverage 91.39% 91.31% -0.08%
==========================================
Files 193 193
Lines 15715 15720 +5
==========================================
- Hits 14362 14355 -7
- Misses 1353 1365 +12 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@pyansys-ci-bot LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use enum instead of just strings.
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)