Enable --offline to affect checking version online #4283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavcrosby
requested review from
alisonlhart and
audgirka
and removed request for
a team
cavcrosby
force-pushed
the
enable-offline-version-online
branch
from
9be13f8 to
20898a9
Compare
alisonlhart
previously requested changes
Aug 16, 2024
Contributor
alisonlhart
left a comment
alisonlhart
left a comment
There was a problem hiding this comment.
Looks good! Will need an update to PYTEST_REQPASS before merging.
cavcrosby
force-pushed
the
enable-offline-version-online
branch
from
2557074 to
deb79f7
Compare
A conditional has been added to see if data is empty to prevent KeyError exceptions from happening because a cache file may not exist when using the --offline flag. This prevents data from ever being populated.
cavcrosby
force-pushed
the
enable-offline-version-online
branch
from
deb79f7 to
52cec64
Compare
|
audgirka
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4269.