Remove EM from ruff ignores (#3356)

Author: shatakshiiii

pyproject.toml

@@ -232,7 +232,6 @@ ignore = [
   "BLE",
   "D",
   "RET",
-  "EM",
   "EXE",
   "FBT",
   "INP",

src/ansiblelint/__main__.py

@@ -424,7 +424,8 @@ def path_inject() -> None:  # noqa: C901
     # our dependency, but addressing this would be done by ansible-compat.
     for cmd in ("ansible", "git"):
         if not shutil.which(cmd):
-            raise RuntimeError(f"Failed to find runtime dependency '{cmd}' in PATH")
+            msg = f"Failed to find runtime dependency '{cmd}' in PATH"
+            raise RuntimeError(msg)
 
 
 # Based on Ansible implementation

src/ansiblelint/cli.py

@@ -88,7 +88,8 @@ def load_config(config_file: str | None) -> tuple[dict[Any, Any], str | None]:
 
     config = clean_json(config_lintable.data)
     if not isinstance(config, dict):
-        raise RuntimeError("Schema failed to properly validate the config file.")
+        msg = "Schema failed to properly validate the config file."
+        raise RuntimeError(msg)
     config["config_file"] = config_path
     config_dir = os.path.dirname(config_path)
     expand_to_normalized_paths(config, config_dir)
@@ -158,9 +159,11 @@ def __init__(  # pylint: disable=too-many-arguments,redefined-builtin
     ) -> None:
         """Create the argparse action with WriteArg-specific defaults."""
         if nargs is not None:
-            raise ValueError("nargs for WriteArgAction must not be set.")
+            msg = "nargs for WriteArgAction must not be set."
+            raise ValueError(msg)
         if const is not None:
-            raise ValueError("const for WriteArgAction must not be set.")
+            msg = "const for WriteArgAction must not be set."
+            raise ValueError(msg)
         super().__init__(
             option_strings=option_strings,
             dest=dest,
@@ -589,9 +592,8 @@ def get_config(arguments: list[str]) -> Options:
         )
 
     if not options.project_dir or not os.path.exists(options.project_dir):
-        raise RuntimeError(
-            f"Failed to determine a valid project_dir: {options.project_dir}",
-        )
+        msg = f"Failed to determine a valid project_dir: {options.project_dir}"
+        raise RuntimeError(msg)
 
     # Compute final verbosity level by subtracting -q counter.
     options.verbosity -= options.quiet

src/ansiblelint/config.py

@@ -168,7 +168,8 @@ def get_rule_config(rule_id: str) -> dict[str, Any]:
     """Get configurations for the rule ``rule_id``."""
     rule_config = options.rules.get(rule_id, {})
     if not isinstance(rule_config, dict):  # pragma: no branch
-        raise RuntimeError(f"Invalid rule config for {rule_id}: {rule_config}")
+        msg = f"Invalid rule config for {rule_id}: {rule_config}"
+        raise RuntimeError(msg)
     return rule_config
 
 

src/ansiblelint/errors.py

@@ -57,22 +57,18 @@ def __init__(
         super().__init__(message)
 
         if rule.__class__ is RuntimeErrorRule and not message:
-            raise TypeError(
-                f"{self.__class__.__name__}() missing a "
-                "required argument: one of 'message' or 'rule'",
-            )
+            msg = f"{self.__class__.__name__}() missing a required argument: one of 'message' or 'rule'"
+            raise TypeError(msg)
 
         self.message = str(message or getattr(rule, "shortdesc", ""))
 
         # Safety measure to ensure we do not end-up with incorrect indexes
         if lineno == 0:  # pragma: no cover
-            raise RuntimeError(
-                "MatchError called incorrectly as line numbers start with 1",
-            )
+            msg = "MatchError called incorrectly as line numbers start with 1"
+            raise RuntimeError(msg)
         if column == 0:  # pragma: no cover
-            raise RuntimeError(
-                "MatchError called incorrectly as column numbers start with 1",
-            )
+            msg = "MatchError called incorrectly as column numbers start with 1"
+            raise RuntimeError(msg)
 
         self.lineno = lineno
         self.column = column

src/ansiblelint/file_utils.py

@@ -309,7 +309,8 @@ def content(self, value: str) -> None:
         has not already been populated.
         """
         if not isinstance(value, str):
-            raise TypeError(f"Expected str but got {type(value)}")
+            msg = f"Expected str but got {type(value)}"
+            raise TypeError(msg)
         if self._original_content is None:
             if self._content is not None:
                 self._original_content = self._content

src/ansiblelint/formatters/__init__.py

@@ -137,9 +137,8 @@ class CodeclimateJSONFormatter(BaseFormatter[Any]):
     def format_result(self, matches: list[MatchError]) -> str:
         """Format a list of match errors as a JSON string."""
         if not isinstance(matches, list):
-            raise RuntimeError(
-                f"The {self.__class__} was expecting a list of MatchError.",
-            )
+            msg = f"The {self.__class__} was expecting a list of MatchError."
+            raise RuntimeError(msg)
 
         result = []
         for match in matches:
@@ -205,9 +204,8 @@ class SarifFormatter(BaseFormatter[Any]):
     def format_result(self, matches: list[MatchError]) -> str:
         """Format a list of match errors as a JSON string."""
         if not isinstance(matches, list):
-            raise RuntimeError(
-                f"The {self.__class__} was expecting a list of MatchError.",
-            )
+            msg = f"The {self.__class__} was expecting a list of MatchError."
+            raise RuntimeError(msg)
 
         root_path = Path(str(self._base_dir)).as_uri()
         root_path = root_path + "/" if not root_path.endswith("/") else root_path

src/ansiblelint/generate_docs.py

@@ -46,9 +46,8 @@ def rules_as_md(rules: RulesCollection) -> str:
 
         if rule.help:
             if not rule.help.startswith(f"# {rule.id}"):  # pragma: no cover
-                raise RuntimeError(
-                    f"Rule {rule.__class__} markdown help does not start with `# {rule.id}` header.\n{rule.help}",
-                )
+                msg = f"Rule {rule.__class__} markdown help does not start with `# {rule.id}` header.\n{rule.help}"
+                raise RuntimeError(msg)
             result += f"\n\n{rule.help}"
         else:
             description = rule.description

src/ansiblelint/loaders.py

@@ -56,9 +56,8 @@ def load_ignore_txt(filepath: Path | None = None) -> dict[str, set[str]]:
                     try:
                         path, rule = entry.split()
                     except ValueError as exc:
-                        raise RuntimeError(
-                            f"Unable to parse line '{line}' from {ignore_file} file.",
-                        ) from exc
+                        msg = f"Unable to parse line '{line}' from {ignore_file} file."
+                        raise RuntimeError(msg) from exc
                     result[path].add(rule)
 
     return result

src/ansiblelint/rules/galaxy.py

@@ -152,7 +152,8 @@ def _coerce(other: object) -> Version:
         other = Version(str(other))
     if isinstance(other, Version):
         return other
-    raise NotImplementedError(f"Unable to coerce object type {type(other)} to Version")
+    msg = f"Unable to coerce object type {type(other)} to Version"
+    raise NotImplementedError(msg)
 
 
 if "pytest" in sys.modules: