Bugfix for duplicate prefix on first prerelease tag #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@anothrNick When you get a chance can you take a look at this one please. |
imbarwinata
approved these changes
May 15, 2025
|
fixed my issues, currently working off the fork resolved prerelease double v. |
Jatin887
approved these changes
May 23, 2025
|
Fixed my issue as well, thanks! |
|
Thanks @rorybartie , |
amalpaul54111
approved these changes
Jul 30, 2025
amalpaul54111
left a comment
amalpaul54111
left a comment
There was a problem hiding this comment.
Yeah, this should help.
Its a blocker for me.
Contributor
|
@anothrNick When you get a moment could you approve and merge in please? |
anothrNick
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Removed the
tagPrefixfrom the new tag when creating a.0prerelease tag. The prefix already gets added to thenewvariable at lines 178 to 198.This should fix a bug that was introduced in PR #326
Breaking Changes
Do any of the included changes break current behaviour or configuration?
NO
How changes have been tested
List any unknowns