Conditionally skip fee checks in masp txs #4730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
approved these changes
Jul 14, 2025
mateuszjasiuk
approved these changes
Jul 14, 2025
Contributor
mateuszjasiuk
left a comment
mateuszjasiuk
left a comment
There was a problem hiding this comment.
Works ok with namadillo!
tzemanovic
added a commit
that referenced
this pull request
Jul 16, 2025
* origin/grarco/skip-masp-fees: Changelog #4730 Adds flag to skip fee checks in masp txs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a flag in the SDK builders to conditionally skip fee checks for txs requiring MASP fee payment. This is a temporary solution to allow building masp batches where only the first tx pay fees. A better approach will require addressing #3901 and #3883 first
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo