Fix masp height overflow in SDK #4725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grarco
added
MASP
SDK
audit
breaking:consensus
grarco
force-pushed
the
grarco/fix-masp-height-overflow
branch
from
dd3e2b3 to
2878ba4
Compare
tzemanovic
approved these changes
Jul 14, 2025
sug0
approved these changes
Jul 15, 2025
tzemanovic
added a commit
that referenced
this pull request
Jul 16, 2025
* origin/grarco/fix-masp-height-overflow: Error out on missing block Fixes broken migration test Adjusts block height in dry-run Fixes broken tests Changelog #4725 Improves masp expiration tests Fixes possible expiration overflow in masp tx construction
Collaborator
|
Can this be merged? |
Collaborator
Author
Yes It's already scheduled for the upcoming release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes a bug for which the desired expiration height of a masp transaction could overflow during the building process
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo