Skip to content

params/vp: check that changed params can be decoded #4708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2025
Merged

params/vp: check that changed params can be decoded #4708

merged 2 commits into from
Jul 15, 2025

Conversation

@tzemanovic
Copy link
Collaborator

@tzemanovic tzemanovic commented Jun 24, 2025 •
edited
Loading

Describe your changes

This is a compatible change because params can only be changed via a passed gov proposal and we don't charge gas for executing those

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic marked this pull request as ready for review June 24, 2025 14:14
@github-actions github-actions bot added the breaking:api public API breaking change label Jun 24, 2025
@tzemanovic tzemanovic added backport-libs-0.150 Backport to libraries 0.150 maintenance branch validity-predicate and removed breaking:api public API breaking change labels Jun 24, 2025
@tzemanovic tzemanovic requested a review from brentstone June 24, 2025 14:32
@tzemanovic tzemanovic requested review from Fraccaman and removed request for brentstone July 15, 2025 12:26
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jul 15, 2025
@tzemanovic tzemanovic merged commit 1da4ae6 into main Jul 15, 2025
24 checks passed
@tzemanovic tzemanovic deleted the tomas/params-vp-extra-check branch July 15, 2025 16:31
mergify bot pushed a commit that referenced this pull request Jul 15, 2025
@tzemanovic @mergify
changelog: add #4708
9a65234 
(cherry picked from commit c8e8ed3)
@mergify mergify bot mentioned this pull request Jul 15, 2025
Merged
3 tasks
tzemanovic added a commit that referenced this pull request Jul 16, 2025
@tzemanovic
Merge branch 'mergify/bp/maint-libs-0.150/pr-4708' (#4735)
fba4e2b 
* origin/mergify/bp/maint-libs-0.150/pr-4708:
  changelog: add #4708
  params/vp: check that changed params can be decoded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fraccaman Fraccaman Fraccaman approved these changes

Assignees

No one assigned

Labels

backport-libs-0.150 Backport to libraries 0.150 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass validity-predicate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tzemanovic @Fraccaman