Indexer client backoff sleep #4702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/indexer-client-backoff-sleep
branch
2 times, most recently
from
e4c5ded to
a1c6693
Compare
batconjurer
reviewed
Jun 19, 2025
Collaborator
batconjurer
left a comment
batconjurer
left a comment
There was a problem hiding this comment.
This works fine, but it might be nicer to rename the old trait funcs *_inner and then have the default impls on the trait wrap the *_inner funcs with the with_retry function. That way future trait impls don't make the same mistake
sug0
force-pushed
the
tiago/indexer-client-backoff-sleep
branch
from
6165b4f to
76788fd
Compare
batconjurer
approved these changes
Jun 20, 2025
Collaborator
batconjurer
left a comment
batconjurer
left a comment
There was a problem hiding this comment.
Looks a lot better, thanks!
Collaborator
|
@sug0 @jurevans @mateuszjasiuk is this important to have in the near-future? |
Collaborator
Author
|
@brentstone I think it might help with request throttling when reverse proxying indexer queries through some CDNs |
mateuszjasiuk
approved these changes
Jul 16, 2025
Contributor
mateuszjasiuk
left a comment
mateuszjasiuk
left a comment
There was a problem hiding this comment.
Works fine with namadillo
mateuszjasiuk
approved these changes
Jul 16, 2025
sug0
added
the
merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add backoff sleep between MASP indexer client failed requests.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo