Skip to content

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented Jun 5, 2025

Describe your changes

Supersedes #4647

The likelihood of this being a consensus breaking upgrade is nearly null, but it's still safer to upgrade to a software release containing this PR in a hardfork.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@github-actions github-actions bot added the breaking:api public API breaking change label Jun 5, 2025
@sug0 sug0 force-pushed the tiago+tomas/faster-gas branch from 0442729 to 94439bd Compare June 11, 2025 10:51
@sug0 sug0 changed the title Tiago+tomas/faster gas Meter wasm gas using mutable global Jun 11, 2025
@sug0 sug0 force-pushed the tiago+tomas/faster-gas branch from 94439bd to adf02ab Compare June 11, 2025 10:58
sug0 added a commit that referenced this pull request Jun 11, 2025
@sug0 sug0 added ledger wasm enhancement New feature or request labels Jun 11, 2025
@sug0 sug0 requested review from grarco and tzemanovic June 11, 2025 11:00
@sug0
Copy link
Collaborator Author

sug0 commented Jun 11, 2025

failures:
    wasm::run::tests::test_tx_stack_limiter
    wasm::run::tests::test_vp_stack_limiter

the stack limiter tests are now failing... hmmm. the changes we've made to wasm affect the stack limiter code that's been injected, after all, so these are probably consensus breaking changes

EDIT: fixed the test by forking wasm-instrument, changing the behavior of the stack limiter instrumenting code to allow specifying a list of functions exempt of instrumentation

sug0 added a commit that referenced this pull request Jun 20, 2025
@sug0 sug0 force-pushed the tiago+tomas/faster-gas branch from 42634d5 to beb97a5 Compare June 20, 2025 12:06
sug0 added a commit that referenced this pull request Jun 20, 2025
@sug0 sug0 force-pushed the tiago+tomas/faster-gas branch from beb97a5 to 5bc6189 Compare June 20, 2025 12:16
sug0 added a commit that referenced this pull request Jul 4, 2025
@sug0 sug0 force-pushed the tiago+tomas/faster-gas branch from 5bc6189 to 5251068 Compare July 4, 2025 09:42
@sug0 sug0 force-pushed the tiago+tomas/faster-gas branch from 5251068 to e1e2962 Compare July 4, 2025 12:44
@sug0 sug0 requested a review from grarco July 4, 2025 12:45
@sug0 sug0 merged commit 40be1d6 into main Jul 16, 2025
24 checks passed
@sug0 sug0 deleted the tiago+tomas/faster-gas branch July 16, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:api public API breaking change enhancement New feature or request ledger wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants