-
Notifications
You must be signed in to change notification settings - Fork 1k
Meter wasm gas using mutable global #4685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0442729 to
94439bd
Compare
94439bd to
adf02ab
Compare
Collaborator
Author
the stack limiter tests are now failing... hmmm. the changes we've made to wasm affect the stack limiter code that's been injected, after all, so these are probably consensus breaking changes EDIT: fixed the test by forking |
42634d5 to
beb97a5
Compare
beb97a5 to
5bc6189
Compare
grarco
reviewed
Jul 3, 2025
grarco
reviewed
Jul 3, 2025
grarco
reviewed
Jul 3, 2025
grarco
reviewed
Jul 3, 2025
grarco
reviewed
Jul 3, 2025
grarco
reviewed
Jul 3, 2025
5bc6189 to
5251068
Compare
5251068 to
e1e2962
Compare
grarco
approved these changes
Jul 4, 2025
tzemanovic
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Supersedes #4647
The likelihood of this being a consensus breaking upgrade is nearly null, but it's still safer to upgrade to a software release containing this PR in a hardfork.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo