Skip to content

Conversation

@tzemanovic
Copy link
Collaborator

Describe your changes

closes #4034

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

tzemanovic added a commit that referenced this pull request Nov 20, 2024
@tzemanovic tzemanovic force-pushed the tomas/wrap-tx-by-elsewho branch from fc33aea to 5e937fc Compare November 20, 2024 11:09
@tzemanovic tzemanovic force-pushed the tomas/wrap-tx-by-elsewho branch from 5e937fc to bf217aa Compare November 20, 2024 11:11
@tzemanovic tzemanovic marked this pull request as ready for review November 20, 2024 11:11
@tzemanovic tzemanovic requested a review from grarco November 20, 2024 11:11
@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.34%. Comparing base (47fc912) to head (dc0904f).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4055      +/-   ##
==========================================
+ Coverage   74.25%   74.34%   +0.08%     
==========================================
  Files         341      341              
  Lines      107271   107273       +2     
==========================================
+ Hits        79651    79748      +97     
+ Misses      27620    27525      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment but this PR looks good to me, thanks for testing this flow!

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 20, 2024
mergify bot added a commit that referenced this pull request Nov 20, 2024
mergify bot added a commit that referenced this pull request Nov 20, 2024
mergify bot added a commit that referenced this pull request Nov 20, 2024
@mergify mergify bot merged commit 963df54 into main Nov 20, 2024
24 checks passed
@mergify mergify bot deleted the tomas/wrap-tx-by-elsewho branch November 20, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test a raw tx and wrapped tx signed by different account holder

3 participants