Skip to content

Conversation

@brentstone
Copy link
Collaborator

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.08%. Comparing base (e768857) to head (755c4ad).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
crates/proof_of_stake/src/rewards.rs 50.00% 4 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
- Coverage   74.09%   74.08%   -0.01%     
==========================================
  Files         341      341              
  Lines      107204   107213       +9     
==========================================
+ Hits        79428    79432       +4     
- Misses      27776    27781       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@brentstone brentstone added this to the v0.46.0 milestone Nov 14, 2024
@brentstone brentstone added merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass client labels Nov 20, 2024
mergify bot added a commit that referenced this pull request Nov 20, 2024
mergify bot added a commit that referenced this pull request Nov 20, 2024
@mergify mergify bot merged commit c61ef69 into main Nov 20, 2024
@mergify mergify bot deleted the brent/dryrun-fixups branch November 20, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when quering for staking rewards in epoch 0

3 participants