Skip to content

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented Nov 5, 2024

Describe your changes

  • Increase masp fee payment gas limit to 65000
  • Test NAM reward unshields in values_spanning_multiple_masp_digits.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@sug0 sug0 added the testing label Nov 5, 2024
@sug0 sug0 requested a review from grarco November 5, 2024 11:57
@sug0 sug0 force-pushed the tiago/test-unshields-multiple-digits branch from 4a5323c to 9316949 Compare November 5, 2024 12:00
@sug0 sug0 added the MASP label Nov 5, 2024
@grarco
Copy link
Collaborator

grarco commented Nov 5, 2024

@sug0 with the increased gas for masp fee payment I believe this could close #3961

@sug0 sug0 force-pushed the tiago/test-unshields-multiple-digits branch from 9316949 to 2bee742 Compare November 5, 2024 13:27
@sug0 sug0 added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 5, 2024
@sug0
Copy link
Collaborator Author

sug0 commented Nov 5, 2024

@Fraccaman ci is doing weird things here 😳

@Fraccaman
Copy link
Collaborator

what is happening?

@sug0
Copy link
Collaborator Author

sug0 commented Nov 5, 2024

test-integration is timing out in a weird way. it fails, but every step in the job succeeds

@Fraccaman
Copy link
Collaborator

just re-run it, no idea why it happen sometimes

@grarco
Copy link
Collaborator

grarco commented Nov 5, 2024

just re-run it, no idea why it happen sometimes

Reran it 3 times, still no luck

@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.88%. Comparing base (a871c33) to head (2bee742).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3982   +/-   ##
=======================================
  Coverage   73.88%   73.88%           
=======================================
  Files         341      341           
  Lines      106444   106444           
=======================================
  Hits        78647    78647           
  Misses      27797    27797           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mergify bot added a commit that referenced this pull request Nov 5, 2024
@mergify mergify bot merged commit c8154b6 into main Nov 5, 2024
24 checks passed
@mergify mergify bot deleted the tiago/test-unshields-multiple-digits branch November 5, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants