Skip to content

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented Nov 4, 2024

Describe your changes

Restore commits accidentally purged from #3959 (more specifically, acafd29)

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@sug0 sug0 requested a review from grarco November 4, 2024 20:27
@sug0 sug0 changed the title Restore commits purged from #3959 Enforce gas spending key usage with disposable gas payers Nov 5, 2024
@sug0 sug0 added merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass cli MASP labels Nov 5, 2024
@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.88%. Comparing base (0e36167) to head (a871c33).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/shielded_token/src/masp/shielded_wallet.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3979      +/-   ##
==========================================
- Coverage   73.95%   73.88%   -0.07%     
==========================================
  Files         341      341              
  Lines      106442   106444       +2     
==========================================
- Hits        78716    78647      -69     
- Misses      27726    27797      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mergify bot added a commit that referenced this pull request Nov 5, 2024
@mergify mergify bot merged commit 03d9a58 into main Nov 5, 2024
22 of 24 checks passed
@mergify mergify bot deleted the tiago/restore-purged-commits branch November 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants