Skip to content

Conversation

@brentstone
Copy link
Collaborator

Describe your changes

Closes #3932

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.88%. Comparing base (9a06dae) to head (67b957a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3947   +/-   ##
=======================================
  Coverage   73.88%   73.88%           
=======================================
  Files         341      341           
  Lines      106463   106463           
=======================================
  Hits        78663    78663           
  Misses      27800    27800           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman requested a review from sug0 October 24, 2024 14:52
@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 5, 2024
mergify bot added a commit that referenced this pull request Nov 5, 2024
@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

Hey @brentstone, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@sug0
Copy link
Collaborator

sug0 commented Nov 5, 2024

needs to be rebased on the new main to increase the integration test timeout :(

@sug0 sug0 force-pushed the brent/update-flume branch from 94b3144 to a63d16a Compare November 6, 2024 16:44
@sug0
Copy link
Collaborator

sug0 commented Nov 6, 2024

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@sug0 sug0 added bug Something isn't working SDK wasm dependencies labels Nov 6, 2024
@Fraccaman
Copy link
Collaborator

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

queue

🟠 Waiting for conditions to match

Details
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue backport-0.44-queue]
      • base = 0.44.0
      • any of: [🛡 GitHub branch protection]
        • check-neutral = test-integration
        • check-skipped = test-integration
        • check-success = test-integration
      • #approved-reviews-by >= 1
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e-with-device-automation
        • check-neutral = test-e2e-with-device-automation
        • check-skipped = test-e2e-with-device-automation
      • any of: [🛡 GitHub branch protection]
        • check-success = check-benchmarks
        • check-neutral = check-benchmarks
        • check-skipped = check-benchmarks
      • any of: [🛡 GitHub branch protection]
        • check-success = check-packages
        • check-neutral = check-packages
        • check-skipped = check-packages
      • any of: [🛡 GitHub branch protection]
        • check-success = build-binaries
        • check-neutral = build-binaries
        • check-skipped = build-binaries
      • any of: [🛡 GitHub branch protection]
        • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
        • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
        • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
      • any of: [🛡 GitHub branch protection]
        • check-success = lints
        • check-neutral = lints
        • check-skipped = lints
      • any of: [🛡 GitHub branch protection]
        • check-success = rust-docs
        • check-neutral = rust-docs
        • check-skipped = rust-docs
      • any of: [🛡 GitHub branch protection]
        • check-success = test-wasm
        • check-neutral = test-wasm
        • check-skipped = test-wasm
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (0)
        • check-neutral = test-e2e (0)
        • check-skipped = test-e2e (0)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (1)
        • check-neutral = test-e2e (1)
        • check-skipped = test-e2e (1)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (2)
        • check-neutral = test-e2e (2)
        • check-skipped = test-e2e (2)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (3)
        • check-neutral = test-e2e (3)
        • check-skipped = test-e2e (3)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (4)
        • check-neutral = test-e2e (4)
        • check-skipped = test-e2e (4)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-unit
        • check-neutral = test-unit
        • check-skipped = test-unit
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Mergify Merge Protections
        • check-skipped = Mergify Merge Protections
        • check-success = Mergify Merge Protections
    • all of: [📌 queue conditions of queue main-queue]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = test-integration
        • check-skipped = test-integration
        • check-success = test-integration
      • #approved-reviews-by >= 1
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • base = main
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e-with-device-automation
        • check-neutral = test-e2e-with-device-automation
        • check-skipped = test-e2e-with-device-automation
      • any of: [🛡 GitHub branch protection]
        • check-success = check-benchmarks
        • check-neutral = check-benchmarks
        • check-skipped = check-benchmarks
      • any of: [🛡 GitHub branch protection]
        • check-success = check-packages
        • check-neutral = check-packages
        • check-skipped = check-packages
      • any of: [🛡 GitHub branch protection]
        • check-success = build-binaries
        • check-neutral = build-binaries
        • check-skipped = build-binaries
      • any of: [🛡 GitHub branch protection]
        • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
        • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
        • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
      • any of: [🛡 GitHub branch protection]
        • check-success = lints
        • check-neutral = lints
        • check-skipped = lints
      • any of: [🛡 GitHub branch protection]
        • check-success = rust-docs
        • check-neutral = rust-docs
        • check-skipped = rust-docs
      • any of: [🛡 GitHub branch protection]
        • check-success = test-wasm
        • check-neutral = test-wasm
        • check-skipped = test-wasm
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (0)
        • check-neutral = test-e2e (0)
        • check-skipped = test-e2e (0)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (1)
        • check-neutral = test-e2e (1)
        • check-skipped = test-e2e (1)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (2)
        • check-neutral = test-e2e (2)
        • check-skipped = test-e2e (2)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (3)
        • check-neutral = test-e2e (3)
        • check-skipped = test-e2e (3)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-e2e (4)
        • check-neutral = test-e2e (4)
        • check-skipped = test-e2e (4)
      • any of: [🛡 GitHub branch protection]
        • check-success = test-unit
        • check-neutral = test-unit
        • check-skipped = test-unit
      • any of: [🛡 GitHub branch protection]
        • check-neutral = Mergify Merge Protections
        • check-skipped = Mergify Merge Protections
        • check-success = Mergify Merge Protections
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@Fraccaman
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

rebase

✅ Branch has been successfully rebased

@Fraccaman
Copy link
Collaborator

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 44292b0

@mergify mergify bot merged commit 44292b0 into main Nov 7, 2024
@mergify mergify bot deleted the brent/update-flume branch November 7, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass SDK wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update flume

4 participants