-
Notifications
You must be signed in to change notification settings - Fork 1k
Offline wrapper signing #3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Offline wrapper signing #3900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b4538b to
3840987
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3900 +/- ##
==========================================
- Coverage 74.02% 73.99% -0.04%
==========================================
Files 341 341
Lines 106560 106608 +48
==========================================
+ Hits 78879 78880 +1
- Misses 27681 27728 +47 ☔ View full report in Codecov by Sentry. |
Fraccaman
approved these changes
Oct 22, 2024
14147c8 to
39f2c11
Compare
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🛡 GitHub branch protections and repository rulesets requirements
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking:client
Namada client breaking change
breaking:SDK
SDK breaking change
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3875.
Updates the client and the SDK (in a breaking manner) to:
customtxSome misc updates to allow the ones above:
ownerarg to be optional forcustomtx andofflinesigningbuild_customoptionally returnsSigningTxData(it returnsNoneif all the signatures have been provided from file)I've also opened #3901 as a possible followup to this PR.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo