Skip to content

Conversation

@grarco
Copy link
Collaborator

@grarco grarco commented Sep 30, 2024

Describe your changes

Partially addresses #3828.

  • Adds unit tests for gas payment with whitelisted, non-native token
  • Adds unit tests for batched txs' events
  • Removes the unused Success event
  • Misc refactor of tx signatures in unit tests

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (5a5e212) to head (9625834).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3857      +/-   ##
==========================================
- Coverage   73.04%   73.04%   -0.01%     
==========================================
  Files         340      340              
  Lines      104815   104781      -34     
==========================================
- Hits        76561    76533      -28     
+ Misses      28254    28248       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco marked this pull request as ready for review September 30, 2024 17:29
@grarco grarco requested a review from tzemanovic September 30, 2024 17:52
@tzemanovic tzemanovic added backport-44 merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass labels Oct 1, 2024
@mergify mergify bot merged commit 48cece5 into main Oct 1, 2024
@mergify mergify bot deleted the grarco/batch-events-tests branch October 1, 2024 09:43
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
(cherry picked from commit 9625834)
@mergify mergify bot mentioned this pull request Oct 1, 2024
3 tasks
tzemanovic added a commit that referenced this pull request Oct 2, 2024
* origin/mergify/bp/0.44.0/pr-3857:
  Changelog #3857
  Removes unused `Success` event
  Adds test for identical events in batch
  Adds batch events tests
  Removes eprintln from prepare proposal unit tests
  Adds tests for whitelisted tokens gas payment
tzemanovic added a commit that referenced this pull request Oct 11, 2024
* 0.44.0:
  Namada 0.44.1
  Removes old reference to encrypted txs
  test/e2e/ibc: try to kill gaiad before running it
  Fixes broken assertions in integration tests
  Update crates/sdk/src/queries/vp/pos.rs
  small fix from comments
  changelog: add #3899
  fix up liveness queries
  Add new rpc query function to check validators' liveness(uptime) in this epoch
  test/e2e: try to forward Ctrl+C to the bg session
  Changelog for #3860
  feat: serde rename batch index into masp tx index
  Tries to drop bg process in tests
  mergify: unquote base branch name
  Changelog #3882
  Extends batch sections test to check duplicate sections
  Custom `PartialEq` impl for `SigningTxData`
  Fixes cmt reference in `add_inner_tx`
  Avoids duplicated sections when contructing a batch
  ci/mergify: unquote base name
  Increases timeout on epoch sleep
  Improves epoch sleeping in ibc tests and renames token variable
  Changelog #3866
  Sped up ibc token test
  Fixes ibc gas payment test
  Fixes typos and updates docstring
  e2e test for ibc token gas payment
  goveranance: let validator vote even if it doesn't have a self-bond
  changelog: add #3835
  tx: test tx sections api
  tx: improve the serialization api
  test/tx: add more unit tests
  tx: split out tx sections into dedicated mod
  tx: move signing related code into sign mod
  tx: rm unsued `SignedTxData`
  refactor and test signature index
  tx/types: rm unused code
  test/e2e: no dbg logs in shielded sync
  ci/mergify: add merge rule for backport to 0.44
  mergify: add backport strategy
  Changelog #3857
  Removes unused `Success` event
  Adds test for identical events in batch
  Adds batch events tests
  Removes eprintln from prepare proposal unit tests
  Adds tests for whitelisted tokens gas payment
  update hermes
  test/e2e: increase hermes timeout
  README: add notes about hermes
  update hermes
  ci: run checks on release branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass non-breaking-change testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants