-
Notifications
You must be signed in to change notification settings - Fork 1k
Masp tests #3840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Masp tests #3840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3840 +/- ##
==========================================
+ Coverage 73.21% 73.25% +0.03%
==========================================
Files 341 341
Lines 105280 105334 +54
==========================================
+ Hits 77081 77158 +77
+ Misses 28199 28176 -23 ☔ View full report in Codecov by Sentry. |
batconjurer
reviewed
Sep 27, 2024
| ], | ||
| )?; | ||
| node.assert_success(); | ||
| let file_path = tempdir |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you love to see it
ad1b001 to
550c623
Compare
batconjurer
approved these changes
Oct 14, 2024
3 tasks
mergify bot
added a commit
that referenced
this pull request
Oct 14, 2024
Masp tests (backport #3840)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Partially addresses #3836.
Partially addresses #3828.
Adds more integration test for the MASP including some tests with tx batches.
Adds some protests for the MASP vp.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo