-
Notifications
You must be signed in to change notification settings - Fork 1k
env agnostic VPs #3807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
env agnostic VPs #3807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3807 +/- ##
==========================================
+ Coverage 72.69% 72.70% +0.01%
==========================================
Files 338 338
Lines 104467 104536 +69
==========================================
+ Hits 75944 76006 +62
- Misses 28523 28530 +7 ☔ View full report in Codecov by Sentry. |
4fc3d95 to
95c58a6
Compare
95c58a6 to
c812120
Compare
86a00c9 to
c3fe124
Compare
c3fe124 to
a75ad66
Compare
grarco
approved these changes
Sep 13, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Rewrite native VPs to be env-agnostic (WASM or native).
The goal is to:
vpcrate from systems crates that implement their VP to usevp_envinsteadCtxintovp_envso that it can be used directly by crates that depend onvp_envas an implementation oftrait VpEnvthat can be used for testing without additional deps (same refactor has already been applied in this P fortx_envand txCtx)vp_envcan then depend onvmto implement VP eval over WASM without running into dep cycleChecklist before merging
breaking::labels