Skip to content

Conversation

@brentstone
Copy link
Collaborator

@brentstone brentstone commented Aug 29, 2024

Describe your changes

Closes #3474.

Also fixes the validator voting period, which was found to be slightly buggy. Fix a bug left over from #3691.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 95.40230% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (6d1b9da) to head (0877ea8).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
crates/governance/src/utils.rs 96.66% 2 Missing ⚠️
crates/governance/src/storage/proposal.rs 75.00% 1 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3728      +/-   ##
==========================================
+ Coverage   72.47%   72.49%   +0.02%     
==========================================
  Files         338      338              
  Lines      104130   104190      +60     
==========================================
+ Hits        75470    75536      +66     
+ Misses      28660    28654       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/improve-gov-output branch from 75f39d6 to 2e458af Compare August 30, 2024 22:55
@brentstone brentstone marked this pull request as ready for review August 31, 2024 00:07
@brentstone brentstone force-pushed the brent/improve-gov-output branch from bcee781 to 374554f Compare September 4, 2024 03:23
brentstone added a commit that referenced this pull request Sep 4, 2024
@brentstone brentstone force-pushed the brent/improve-gov-output branch from 374554f to 6661ba1 Compare September 4, 2024 10:22
brentstone added a commit that referenced this pull request Sep 4, 2024
@brentstone brentstone force-pushed the brent/improve-gov-output branch from 6661ba1 to 79112e0 Compare September 4, 2024 11:47
@tzemanovic tzemanovic force-pushed the brent/improve-gov-output branch from 79112e0 to 0877ea8 Compare September 6, 2024 11:39
@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 6, 2024
@mergify mergify bot merged commit ef49b3d into main Sep 6, 2024
@mergify mergify bot deleted the brent/improve-gov-output branch September 6, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client feature: helpful, human-readable governance proposal outputs

3 participants