Skip to content

Conversation

@brentstone
Copy link
Collaborator

@brentstone brentstone commented Aug 27, 2024

Describe your changes

Closes #3683

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@brentstone brentstone added the breaking:consensus Consensus breaking change that requires a hard-fork label Aug 27, 2024
@codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.16%. Comparing base (24eebc7) to head (d52f49a).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
crates/governance/src/utils.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3703      +/-   ##
==========================================
- Coverage   61.17%   61.16%   -0.01%     
==========================================
  Files         315      315              
  Lines      103220   103223       +3     
==========================================
- Hits        63141    63135       -6     
- Misses      40079    40088       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone marked this pull request as ready for review August 27, 2024 05:26
@brentstone brentstone requested a review from Fraccaman August 27, 2024 05:26
@brentstone brentstone requested a review from cwgoes August 27, 2024 20:42
@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 29, 2024
mergify bot added a commit that referenced this pull request Aug 29, 2024
@mergify mergify bot merged commit cc0a448 into main Aug 29, 2024
@mergify mergify bot deleted the brent/change-default-gov-quorum branch August 29, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:consensus Consensus breaking change that requires a hard-fork merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard-code all governance proposal types to be 40%

3 participants