Skip to content

Conversation

@grarco
Copy link
Collaborator

@grarco grarco commented Aug 23, 2024

Describe your changes

Closes #3424.

Removes the disposable-gas-payer arg from the general Tx args and makes it specific to a set of transactions:

  • TxShieldedTransfer
  • TxUnshieldingTransfer
  • TxIbc
  • TxCustom
  • The SignTx struct used to sign transactions offline

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@codecov
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 61.16%. Comparing base (2256e38) to head (86f053e).
Report is 7 commits behind head on main.

Files Patch % Lines
crates/sdk/src/tx.rs 0.00% 29 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 7 Missing ⚠️
crates/sdk/src/args.rs 0.00% 6 Missing ⚠️
crates/sdk/src/eth_bridge/bridge_pool.rs 0.00% 2 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3699      +/-   ##
==========================================
- Coverage   61.17%   61.16%   -0.02%     
==========================================
  Files         315      315              
  Lines      103187   103220      +33     
==========================================
+ Hits        63129    63131       +2     
- Misses      40058    40089      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grarco added a commit that referenced this pull request Aug 23, 2024
@grarco grarco marked this pull request as ready for review August 23, 2024 14:17
@grarco grarco force-pushed the grarco/disposable-signer-update branch from a05d0a5 to 8ec7bbe Compare August 23, 2024 14:59
@grarco grarco requested review from Fraccaman and brentstone August 23, 2024 14:59
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some spelling, otherwise LGTM!

@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 26, 2024
@mergify mergify bot merged commit 24eebc7 into main Aug 26, 2024
@mergify mergify bot deleted the grarco/disposable-signer-update branch August 26, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move disposable-gas-payer arg

4 participants