Skip to content

Conversation

@brentstone
Copy link
Collaborator

Describe your changes

Closes #3522

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@codecov
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (d4abfc3) to head (ee8801e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/rpc.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3691      +/-   ##
==========================================
+ Coverage   71.66%   71.67%   +0.01%     
==========================================
  Files         311      311              
  Lines      101496   101508      +12     
==========================================
+ Hits        72733    72752      +19     
+ Misses      28763    28756       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brentstone added a commit that referenced this pull request Aug 23, 2024
@brentstone brentstone marked this pull request as ready for review August 23, 2024 21:58
brentstone added a commit that referenced this pull request Aug 28, 2024
@brentstone brentstone requested a review from tzemanovic August 28, 2024 00:05
@tzemanovic
Copy link
Collaborator

there's a failing integration test - we need to update the expected string in crates/tests/src/integration/ledger_tests.rs:1180

brentstone added a commit that referenced this pull request Aug 29, 2024
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 29, 2024
mergify bot added a commit that referenced this pull request Aug 29, 2024
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2024

Hey @brentstone, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

mergify bot added a commit that referenced this pull request Aug 29, 2024
mergify bot added a commit that referenced this pull request Aug 29, 2024
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2024

Hey @brentstone, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

brentstone added a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI Command Requests

3 participants