Skip to content

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented Aug 21, 2024

Describe your changes

This PR augments the functionality of gen_localnet.py with the ability to generate full node base directories. Moreover, adds a new localnet-2 localnet starter kit with 2 validator nodes, and a script to start from this new localnet with either of the validator nodes or a full node.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@sug0 sug0 added the testing label Aug 21, 2024
@sug0 sug0 requested review from batconjurer and tzemanovic August 21, 2024 11:57
@codecov
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.11%. Comparing base (dbafe50) to head (2f14dc5).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3680      +/-   ##
==========================================
- Coverage   61.11%   61.11%   -0.01%     
==========================================
  Files         315      315              
  Lines      103056   103056              
==========================================
- Hits        62981    62979       -2     
- Misses      40075    40077       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic
Copy link
Collaborator

I think we could use the init-genesis-validator and sign-genesis-txs to add arbitrary number of validators to localnet instead

@sug0
Copy link
Collaborator Author

sug0 commented Aug 21, 2024

that's what I did. I modified the existing localnet dir with those cmds

@tzemanovic
Copy link
Collaborator

that's what I did. I modified the existing localnet dir with those cmds

ah I see. Can we do that so that the script makes it on-demand in a temp dir so we don't need to track localnet-2?

@sug0
Copy link
Collaborator Author

sug0 commented Aug 21, 2024

that's what I did. I modified the existing localnet dir with those cmds

ah I see. Can we do that so that the script makes it on-demand in a temp dir so we don't need to track localnet-2?

sure, should be doable

@sug0 sug0 force-pushed the tiago/gen-localnet-fullnodes branch from 8a6fc01 to 2f14dc5 Compare August 22, 2024 08:27
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 22, 2024
mergify bot added a commit that referenced this pull request Aug 22, 2024
mergify bot added a commit that referenced this pull request Aug 22, 2024
@mergify mergify bot merged commit c9575a3 into main Aug 22, 2024
@mergify mergify bot deleted the tiago/gen-localnet-fullnodes branch August 22, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants