client: print sha256 of proposal wasm #3617
Conversation
| let proposal_code = | ||
| gov_api::get_proposal_code(&shell.state, id)? | ||
| .unwrap_or_default(); | ||
| let _result = execute_default_proposal( | ||
| shell, | ||
| id, | ||
| proposal_code.clone(), | ||
| )?; |
There was a problem hiding this comment.
@grarco I think this is not needed in this branch right?
There was a problem hiding this comment.
Correct and I don't know why it is still there. I swear we talked about this thing already a few months ago and we fixed it.
Anyway, I also see that execute_pgf_funding_proposal returns a boolean that we never use so we might remove that too?
There was a problem hiding this comment.
im now using the result to improve the print statement
There was a problem hiding this comment.
But it looks to me that execute_pgf_funding_proposal only ever returns Ok(true)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3617 +/- ##
=======================================
Coverage 61.18% 61.18%
=======================================
Files 311 311
Lines 101433 101442 +9
=======================================
+ Hits 62059 62069 +10
+ Misses 39374 39373 -1 ☔ View full report in Codecov by Sentry. |
Fraccaman
force-pushed
the
fraccaman/governance-proposal-client-better-hash
branch
from
53d0963 to
bdd18b7
Compare
Fraccaman
force-pushed
the
fraccaman/governance-proposal-client-better-hash
branch
from
bdd18b7 to
8cb793c
Compare
tzemanovic
added
the
merge
mergify
bot
deleted the
fraccaman/governance-proposal-client-better-hash
branch
Describe your changes
Printing the sha256 of the wasm associated with a proposal makes it easier to check the its integrity and validatity.
Checklist before merging
breaking::labels