Skip to content

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented Aug 12, 2024

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@sug0 sug0 marked this pull request as ready for review August 12, 2024 12:22
@codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.27%. Comparing base (dd0e04a) to head (f58bc90).

Files Patch % Lines
crates/apps_lib/src/config/genesis.rs 81.94% 13 Missing ⚠️
crates/apps_lib/src/config/genesis/templates.rs 50.00% 1 Missing ⚠️
crates/apps_lib/src/config/genesis/transactions.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3614      +/-   ##
==========================================
+ Coverage   61.26%   61.27%   +0.01%     
==========================================
  Files         312      312              
  Lines      101268   101338      +70     
==========================================
+ Hits        62037    62093      +56     
- Misses      39231    39245      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 12, 2024
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2024

Hey @sug0, your pull request has been dequeued due to the following reason: CONFLICT_WITH_BASE_BRANCH.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@Fraccaman
Copy link
Collaborator

@sug0 changelog is also missing (its not required but I think we could add it for this PR)

@sug0 sug0 force-pushed the tiago/implicit-addr-balances-toml branch from 7dbc801 to f58bc90 Compare August 13, 2024 08:32
@mergify mergify bot merged commit 8e04d45 into main Aug 13, 2024
@mergify mergify bot deleted the tiago/implicit-addr-balances-toml branch August 13, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants