Skip to content

Conversation

@Fraccaman
Copy link
Collaborator

Describe your changes

Minor refactor to how signing data is fetched.

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@codecov
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (7b052e5) to head (87e939e).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/sdk/src/tx.rs 0.00% 58 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 9 Missing ⚠️
crates/apps_lib/src/client/tx.rs 0.00% 2 Missing ⚠️
crates/sdk/src/eth_bridge/bridge_pool.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
- Coverage   54.55%   54.54%   -0.02%     
==========================================
  Files         323      323              
  Lines      113871   113888      +17     
==========================================
- Hits        62118    62115       -3     
- Misses      51753    51773      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman force-pushed the fraccaman/improve-signers-sdk branch from e0c042a to 86e4c94 Compare August 8, 2024 08:51
@Fraccaman Fraccaman marked this pull request as ready for review August 8, 2024 09:24
@Fraccaman Fraccaman force-pushed the fraccaman/improve-signers-sdk branch 3 times, most recently from f96db78 to 32051f1 Compare August 8, 2024 12:46
@Fraccaman Fraccaman force-pushed the fraccaman/improve-signers-sdk branch from 32051f1 to 87e939e Compare August 8, 2024 12:47
@Fraccaman Fraccaman requested a review from tzemanovic August 8, 2024 13:27
@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 8, 2024
mergify bot added a commit that referenced this pull request Aug 8, 2024
@mergify mergify bot merged commit 682d7ff into main Aug 8, 2024
@mergify mergify bot deleted the fraccaman/improve-signers-sdk branch August 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants