Skip to content

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented Jul 10, 2024

Describe your changes

Supersedes #3405, #3426 (rebase of the last one on the latest release)

Implements phase 1 of Issue #3385

  • When fetching notes, connections and related failures should not halt shielded sync. Instead, the process should be restarted
  • If fetching is interrupted, the data fetched should be persisted locally so that progress isn't lost
  • A trait for fetching behavior should be added to provide modularity

Indicate on which release or other PRs this topic is based on

v0.40.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@sug0 sug0 added enhancement New feature or request client SDK labels Jul 10, 2024
sug0 added a commit that referenced this pull request Jul 10, 2024
@sug0 sug0 force-pushed the tiago/masp-ss-client-phase-1 branch from 64dcf5c to 6b75b03 Compare July 10, 2024 09:11
@sug0 sug0 marked this pull request as ready for review July 10, 2024 09:11
@sug0 sug0 requested a review from grarco July 10, 2024 09:11
@sug0 sug0 mentioned this pull request Jul 10, 2024
2 tasks
@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 75.08091% with 231 lines in your changes missing coverage. Please review.

Project coverage is 54.04%. Comparing base (8479d38) to head (6a18bc1).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/apps_lib/src/client/masp.rs 0.00% 118 Missing ⚠️
crates/sdk/src/masp.rs 88.04% 79 Missing ⚠️
crates/sdk/src/masp/test_utils.rs 84.74% 18 Missing ⚠️
crates/sdk/src/masp/utils.rs 26.31% 14 Missing ⚠️
crates/apps_lib/src/cli/client.rs 0.00% 1 Missing ⚠️
crates/sdk/src/control_flow/mod.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3498      +/-   ##
==========================================
+ Coverage   53.48%   54.04%   +0.56%     
==========================================
  Files         320      322       +2     
  Lines      110000   110866     +866     
==========================================
+ Hits        58832    59920    +1088     
+ Misses      51168    50946     -222     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman mentioned this pull request Jul 10, 2024
@sug0 sug0 requested a review from tzemanovic July 11, 2024 08:02
grarco
grarco previously approved these changes Jul 11, 2024
@sug0 sug0 force-pushed the tiago/masp-ss-client-phase-1 branch from 6b75b03 to 6a18bc1 Compare July 15, 2024 09:55
brentstone added a commit that referenced this pull request Jul 16, 2024
* tiago/masp-ss-client-phase-1:
  Changelog for #3498
  Document origin of obfuscated/opaque masp tx
  Implement a gnarly cross-platform logging iterator
  Implement phase 1 of shielded sync
@brentstone brentstone merged commit 74b417c into main Jul 24, 2024
@brentstone brentstone deleted the tiago/masp-ss-client-phase-1 branch July 24, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client enhancement New feature or request SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants