Phase 2 of Shielded Sync refactor #3456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/masp-ss-phase-2
branch
from
6269712 to
0a439b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3456 +/- ##
==========================================
+ Coverage 53.48% 53.87% +0.38%
==========================================
Files 320 322 +2
Lines 110000 111341 +1341
==========================================
+ Hits 58832 59981 +1149
- Misses 51168 51360 +192 ☔ View full report in Codecov by Sentry. |
Closed
sug0
force-pushed
the
tiago/masp-ss-phase-2
branch
from
300c51a to
ad2033a
Compare
grarco
reviewed
Jul 11, 2024
grarco
reviewed
Jul 11, 2024
grarco
reviewed
Jul 11, 2024
grarco
reviewed
Jul 11, 2024
grarco
reviewed
Jul 11, 2024
tzemanovic
reviewed
Jul 11, 2024
grarco
reviewed
Jul 11, 2024
grarco
reviewed
Jul 11, 2024
grarco
reviewed
Jul 11, 2024
sug0
force-pushed
the
tiago/masp-ss-phase-2
branch
from
7aa3982 to
185cf27
Compare
grarco
approved these changes
Jul 16, 2024
brentstone
added a commit
that referenced
this pull request
Jul 16, 2024
* tiago/masp-ss-phase-2: Changelog for #3456 Remove `ThenAwait` abstraction Remove default methods from masp client trait Deserialize server err response from masp indexer client More misc masp indexer client fixes Fetch indexed txs in batches of the max req thres Inline caps in masp client Misc indexer client fixes Fetch masp pre-built data during shielded sync Integrate indexer client with the CLI Advance peek iterator at the top of loop Optionally trigger witness map update Implement a masp client backed by the `namada-masp-indexer` Decouple ledger rpc client from masp client Remove batch size arg Update `reqwest` Disable building ledger masp client on wasm targets Make masp client caps a default method Add new fetch methods to masp client trait Emit spin loop hint on masp txs receiver Always retry from the latest synced height during ss Use `BlockHeight` instead of `u64` in fetch args Define capabilities for masp rpc clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implements phase 2 of Issue #3385
Indicate on which release or other PRs this topic is based on
Based on #3498
Diff for review: https://github.com/anoma/namada/compare/tiago/masp-ss-client-phase-1..tiago/masp-ss-phase-2
Checklist before merging to
draft