Parameterize gas scale #3391
Merged
Parameterize gas scale #3391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
grarco
reviewed
Jun 9, 2024
grarco
reviewed
Jun 9, 2024
grarco
reviewed
Jun 9, 2024
grarco
reviewed
Jun 9, 2024
grarco
reviewed
Jun 9, 2024
grarco
reviewed
Jun 9, 2024
grarco
reviewed
Jun 9, 2024
grarco
previously approved these changes
Jun 10, 2024
brentstone
added a commit
that referenced
this pull request
Jun 10, 2024
* brent/parameterize-gas-scale: change comment on Gas Display fixes from comments changelog: add #3391 fix and clean up Light error handling remove hard-coded gas scale add gas scale to protocol params
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3391 +/- ##
==========================================
+ Coverage 53.92% 53.95% +0.02%
==========================================
Files 317 317
Lines 107575 107669 +94
==========================================
+ Hits 58011 58089 +78
- Misses 49564 49580 +16 ☔ View full report in Codecov by Sentry. |
brentstone
added a commit
that referenced
this pull request
Jun 12, 2024
* brent/parameterize-gas-scale: fix unit test change comment on Gas Display fixes from comments changelog: add #3391 fix and clean up Light error handling remove hard-coded gas scale add gas scale to protocol params
brentstone
added a commit
that referenced
this pull request
Jun 14, 2024
* brent/parameterize-gas-scale: fix unit test change comment on Gas Display fixes from comments changelog: add #3391 fix and clean up Light error handling remove hard-coded gas scale add gas scale to protocol params
grarco
previously approved these changes
Jun 20, 2024
tzemanovic
reviewed
Jun 24, 2024
brentstone
added a commit
that referenced
this pull request
Jun 28, 2024
* brent/parameterize-gas-scale: Updated example of expected string Fixes ibc e2e test fix unit test change comment on Gas Display fixes from comments changelog: add #3391 fix and clean up Light error handling remove hard-coded gas scale add gas scale to protocol params
brentstone
added a commit
that referenced
this pull request
Jul 4, 2024
* origin/brent/parameterize-gas-scale: Updated example of expected string Fixes ibc e2e test fix unit test change comment on Gas Display fixes from comments changelog: add #3391 fix and clean up Light error handling remove hard-coded gas scale add gas scale to protocol params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1881
Indicate on which release or other PRs this topic is based on
v0.39.0
Checklist before merging to
draft