fix masp rewards underflow #2230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/masp-rewards
branch
from
f99c2d7 to
1e13831
Compare
murisi
approved these changes
Nov 29, 2023
Collaborator
murisi
left a comment
murisi
left a comment
There was a problem hiding this comment.
Nice catch! The normed_inflation in the denominator could be so high that no rewards are given.
tzemanovic
added a commit
that referenced
this pull request
Nov 29, 2023
* origin/tomas/masp-rewards: changelog: add #2230 masp: fix possible underflow masp: test update_allowed_conversions dec: add a proptest helper to gen arb non-negative dec masp: log inflation amount for each token address
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a test for
fn update_allowed_conversionsand fixed a possible underflow (b41393e).Indicate on which release or other PRs this topic is based on
v0.27.0
Checklist before merging to
draft