Removed uses of lifetimes in the SDKs Namada trait and implementation #2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
force-pushed
the
murisi/remove-sdk-lifetimes
branch
from
441db2c to
7a7d771
Compare
sug0
previously approved these changes
Nov 28, 2023
Collaborator
sug0
left a comment
sug0
left a comment
There was a problem hiding this comment.
Nice, this is a big improvement. It should solve many lifetime related annoyances in the SDK.
Closed
Collaborator
|
don't forget to add an sdk changelog |
tzemanovic
previously approved these changes
Nov 28, 2023
murisi
added a commit
that referenced
this pull request
Nov 28, 2023
2 tasks
murisi
added a commit
that referenced
this pull request
Nov 28, 2023
murisi
force-pushed
the
murisi/remove-sdk-lifetimes
branch
from
b096e77 to
8afe908
Compare
murisi
added a commit
that referenced
this pull request
Nov 28, 2023
murisi
added a commit
that referenced
this pull request
Nov 28, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Modified the
Namadatrait and implementation to own its their clients, streams, wallet, and shielded utilities. Then removed all the redundant lifetimes. This was relatively straightforward because it was rare that after aNamadaImplhas been instantiated that any other object would want to own the client, streams, wallet, or shielded utilities.Indicate on which release or other PRs this topic is based on
Namada 0.27.0
Checklist before merging to
draft