Added Ledger support to the wallet. #2118
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added Ledger support to the
namadawcommand, expanded theStoreto also hold derivation paths and public keys, and attempted to simplify the wallet logic. More specifically:namadaw key listcommand remains as informative even in the absence of the secret key (which may be being stored externally on a hardware wallet)store.rsto ensure that the key derivations are always maximized and are done correctly:DerivationPathinstead ofStringledger-namadabranch enabling SLIP10 and returns larger key byte vectors that contain the key discriminant byte: https://github.com/heliaxdev/ledger-namada/tree/murisi/fix-rs-0.24.0ledger-namadabranch fixing the hashing of signature sections involved in multisig transactions: https://github.com/heliaxdev/ledger-namada/tree/murisi/fix-rs-0.24.0Store(de)serializationnamadaw key listcommand to also print out public keys (labelled asexternal) even when no corresponding secret key existscloses #70
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft