Skip to content

Conversation

@tzemanovic
Copy link
Collaborator

@tzemanovic tzemanovic commented Nov 5, 2023

Describe your changes

Follow-up to #2047, we have to remove jemalloc from rocksdb workspace features to support win build.

Indicate on which release or other PRs this topic is based on

0.25.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic changed the title Win build, attemp #2 Win build, attempt #2 Nov 5, 2023
@tzemanovic tzemanovic marked this pull request as ready for review November 5, 2023 17:25
@tzemanovic tzemanovic requested a review from Fraccaman November 5, 2023 17:25
@Fraccaman
Copy link
Collaborator

lets merge this to draft @brentstone

@brentstone brentstone mentioned this pull request Nov 9, 2023
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brentstone added a commit that referenced this pull request Nov 9, 2023
* tomas/win-build-2:
  changelog: #2100
  rm jemalloc from rocksdb workspace features
@tzemanovic tzemanovic merged commit b711fd2 into main Nov 11, 2023
@tzemanovic tzemanovic deleted the tomas/win-build-2 branch November 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants