core/lazy_map+set: avoid calling delete when given key is not present #1984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
approved these changes
Oct 16, 2023
Collaborator
brentstone
left a comment
brentstone
left a comment
There was a problem hiding this comment.
Awesome, I checked the behavior locally in a dummy e2e test env and it works. Thx!
Closed
brentstone
added a commit
that referenced
this pull request
Oct 16, 2023
* tomas/rm-redundant-writes: changelog: add #1984 core/lazy_map+set: avoid calling delete when given key is not present
brentstone
added a commit
that referenced
this pull request
Oct 16, 2023
* tomas/rm-redundant-writes: changelog: add #1984 core/lazy_map+set: avoid calling delete when given key is not present
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/tomas/rm-redundant-writes: changelog: add #1984 core/lazy_map+set: avoid calling delete when given key is not present
tzemanovic
added a commit
that referenced
this pull request
Oct 24, 2023
* tomas/rm-redundant-writes: changelog: add #1984 core/lazy_map+set: avoid calling delete when given key is not present
Merged
brentstone
pushed a commit
that referenced
this pull request
Nov 11, 2023
* tomas/rm-redundant-writes: changelog: add #1984 core/lazy_map+set: avoid calling delete when given key is not present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #1981
Indicate on which release or other PRs this topic is based on
0.23.0
Checklist before merging to
draft