deps: switch from libsecp256k1 to k256 #1958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
changed the title
tzemanovic
added a commit
that referenced
this pull request
Sep 29, 2023
tzemanovic
force-pushed
the
tomas/k256
branch
from
22e7f5e to
88a3912
Compare
tzemanovic
changed the title
2 tasks
sug0
previously approved these changes
Oct 3, 2023
Collaborator
sug0
left a comment
sug0
left a comment
There was a problem hiding this comment.
tested compat w/ an ethereum node and signatures are working.
Collaborator
|
|
batconjurer
previously approved these changes
Oct 4, 2023
Collaborator
|
oops, I removed |
sug0
added a commit
that referenced
this pull request
Oct 13, 2023
Closed
29 tasks
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/tomas/k256: changelog: add #1958 deps: switch to use libseck256k1 to k256
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We already have k256 in transitive deps from e.g.
tendermint-rs. See also a post describing k256: https://iqlusion.blog/k256-crate-pure-rust-projective-secp256k1-libraryIndicate on which release or other PRs this topic is based on
0.23.0
Checklist before merging to
draft