Arbitrary Bridge pool fee token types #1795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/update-ethbridge-rs
branch
from
1ac1406 to
80854c5
Compare
sug0
force-pushed
the
tiago/bridge-pool-fees
branch
3 times, most recently
from
ac1896d to
31e948b
Compare
Collaborator
Author
|
might still add one or two tests to check that the appropriate keys are changed when the fee token is different from NAM, while handling ethereum events |
sug0
force-pushed
the
tiago/bridge-pool-fees
branch
from
35f6022 to
45a956a
Compare
2 tasks
batconjurer
reviewed
Aug 11, 2023
batconjurer
reviewed
Aug 11, 2023
batconjurer
requested changes
Aug 11, 2023
sug0
force-pushed
the
tiago/bridge-pool-fees
branch
from
96cd5ec to
7c404af
Compare
tzemanovic
previously approved these changes
Aug 16, 2023
Co-authored-by: Jacob Turner <[email protected]>
sug0
force-pushed
the
tiago/update-ethbridge-rs
branch
from
80854c5 to
5678ee7
Compare
sug0
force-pushed
the
tiago/bridge-pool-fees
branch
from
7c404af to
968f1a6
Compare
Closed
sug0
added a commit
that referenced
this pull request
Aug 30, 2023
batconjurer
approved these changes
Aug 31, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/bridge-pool-fees: Changelog for #1795 Fix the denomination of Bridge pool gas fees Add `DenominatedAmount::is_zero` Fix docstring Make Bridge pool gas payer CLI arg optional Standardize Bridge pool transfer CLI args Update CLI args for Bridge pool transfers Test paying Bridge pool gas fees in ERC20 tokens Arbitrary gas fees in Ethereum events `init_balances` Fix bug in `determine_escrow_checks` and document corner cases Add misc Bridge pool VP tests Fix test_minting_wnam() unit test Validate different gas fee tokens in Bridge pool VP Check correct gas fee token in Bridge pool transfers Fix compilation errors from prev commit Add token addr field to Bridge pool gas fees Move `check_balance_changes` to Bridge pool VP module
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/bridge-pool-fees: Changelog for #1795 Fix the denomination of Bridge pool gas fees Add `DenominatedAmount::is_zero` Fix docstring Make Bridge pool gas payer CLI arg optional Standardize Bridge pool transfer CLI args Update CLI args for Bridge pool transfers Test paying Bridge pool gas fees in ERC20 tokens Arbitrary gas fees in Ethereum events `init_balances` Fix bug in `determine_escrow_checks` and document corner cases Add misc Bridge pool VP tests Fix test_minting_wnam() unit test Validate different gas fee tokens in Bridge pool VP Check correct gas fee token in Bridge pool transfers Fix compilation errors from prev commit Add token addr field to Bridge pool gas fees Move `check_balance_changes` to Bridge pool VP module
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/bridge-pool-fees: Changelog for #1795 Fix the denomination of Bridge pool gas fees Add `DenominatedAmount::is_zero` Fix docstring Make Bridge pool gas payer CLI arg optional Standardize Bridge pool transfer CLI args Update CLI args for Bridge pool transfers Test paying Bridge pool gas fees in ERC20 tokens Arbitrary gas fees in Ethereum events `init_balances` Fix bug in `determine_escrow_checks` and document corner cases Add misc Bridge pool VP tests Fix test_minting_wnam() unit test Validate different gas fee tokens in Bridge pool VP Check correct gas fee token in Bridge pool transfers Fix compilation errors from prev commit Add token addr field to Bridge pool gas fees Move `check_balance_changes` to Bridge pool VP module
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1704
Doesn't solve #1799 nor #1800
The PR is configured to merge into the base (tiago/update-ethbridge-rs) to make reviewing easier. It should be changed back to
main, once the base is upstreamed.Indicate on which release or other PRs this topic is based on
Based on #1789
Checklist before merging to
draft