Allow ethereum oracle control from ledger. #1764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates sent from ledger
sug0
reviewed
Jul 26, 2023
tzemanovic
previously approved these changes
Jul 28, 2023
Collaborator
|
Pls add a change log |
Collaborator
|
looks like we missed this in the last release |
Collaborator
|
ah totally forgot about this :( should we plan it for 0.25.0 or later? |
Collaborator
|
I think this is not a priority. can add this to a later release |
Closed
tzemanovic
added a commit
that referenced
this pull request
Nov 27, 2023
* origin/bat/feature/disable-oracle-gov: [chore]: Add changelog [fix]: Fixed block height typo in test [feat]: Allow eth-oracle to be activated / deactivated via config updates sent from ledger
tzemanovic
added a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #1726
Allow eth-oracle to be activated / deactivated via config updates sent from ledger. This allows governance to shutdown the ledger w/o restarts and not resulting in the ledger crashing.
This is covered with a test, but it is flaky due to async channel race conditions.