-
Notifications
You must be signed in to change notification settings - Fork 1k
Murisi/disable encryption #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d renamed it to validate_tx.
grarco
previously approved these changes
Jul 2, 2023
Collaborator
grarco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
4011541 to
a327d19
Compare
151720c to
6cdcf8f
Compare
6cdcf8f to
9028fe2
Compare
brentstone
added a commit
that referenced
this pull request
Jul 5, 2023
* murisi/disable-encryption: Added a changelog entry. Stop encrypting transactions in tests. Disable encrypting transactions when sending.
Fraccaman
added a commit
that referenced
this pull request
Jul 6, 2023
* origin/murisi/disable-encryption: Added a changelog entry. Stop encrypting transactions in tests. Disable encrypting transactions when sending.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled encryption when sending transactions. This PR is based on #1607 which fixes a general malleability issue with Namada transactions. More concretely, transactions will go from looking like:
to looking like: