fix(menu): reposition menu if it would open off screen #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
force-pushed
the
menu-position
branch
3 times, most recently
from
b93d246 to
d9b5bd5
Compare
jelbourn
reviewed
Nov 8, 2016
src/lib/menu/menu-trigger.ts
Outdated
| /** Converts the designated point into an OriginConnectionPosition. */ | ||
| private _originPos(x: HorizontalConnectionPos, | ||
| y: VerticalConnectionPos): OriginConnectionPosition { | ||
| return {originX: x, originY: y} as OriginConnectionPosition; |
Member
There was a problem hiding this comment.
Is the as OriginConnectionPosition necessary? The types should be structurally identical.
Contributor
Author
|
Realized I need to change the animation origin point if a fallback is used, so this will need some more work. |
kara
added
pr: needs review
and removed
in progress
kara
force-pushed
the
menu-position
branch
4 times, most recently
from
7d72eba to
8f9dfa6
Compare
jelbourn
reviewed
Nov 16, 2016
src/lib/menu/menu-trigger.ts
Outdated
| * correct, even if a fallback position is used for the overlay. | ||
| */ | ||
| private _subscribeToPositions(position: ConnectedPositionStrategy): void { | ||
| this._positionSubscription = position.onPositionChange.subscribe( |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1540.