fix(directionality): change event now emit the new value (#8424)

Author: EladBezalel

src/cdk/bidi/dir.ts

@@ -34,7 +34,7 @@ export class Dir implements Directionality {
   private _isInitialized: boolean = false;
 
   /** Event emitted when the direction changes. */
-  @Output('dirChange') change = new EventEmitter<void>();
+  @Output('dirChange') change = new EventEmitter<Direction>();
 
   /** @docs-private */
   @Input('dir')
@@ -43,7 +43,7 @@ export class Dir implements Directionality {
     let old = this._dir;
     this._dir = v;
     if (old !== this._dir && this._isInitialized) {
-      this.change.emit();
+      this.change.emit(this._dir);
     }
   }
 

src/cdk/bidi/directionality.spec.ts

@@ -1,7 +1,7 @@
-import {async, fakeAsync, TestBed, tick} from '@angular/core/testing';
+import {async, fakeAsync, TestBed} from '@angular/core/testing';
 import {Component} from '@angular/core';
 import {By} from '@angular/platform-browser';
-import {BidiModule, Directionality, DIR_DOCUMENT} from './index';
+import {BidiModule, Directionality, Direction, DIR_DOCUMENT} from './index';
 
 describe('Directionality', () => {
   let fakeDocument: FakeDocument;
@@ -62,14 +62,18 @@ describe('Directionality', () => {
 
       fixture.detectChanges();
 
+      let direction = injectedDirectionality.value;
+      injectedDirectionality.change.subscribe((dir: Direction) => { direction = dir; });
+
+      expect(direction).toBe('rtl');
       expect(injectedDirectionality.value).toBe('rtl');
       expect(fixture.componentInstance.changeCount).toBe(0);
 
       fixture.componentInstance.direction = 'ltr';
 
       fixture.detectChanges();
-      tick();
 
+      expect(direction).toBe('ltr');
       expect(injectedDirectionality.value).toBe('ltr');
       expect(fixture.componentInstance.changeCount).toBe(1);
     }));
@@ -79,7 +83,7 @@ describe('Directionality', () => {
 
 @Component({
   template: `
-    <div [dir]="direction" (dirChange)="changeCount= changeCount + 1">
+    <div [dir]="direction" (dirChange)="changeCount = changeCount + 1">
       <injects-directionality></injects-directionality>
     </div>
   `

src/cdk/bidi/directionality.ts

@@ -39,7 +39,7 @@ export class Directionality {
   readonly value: Direction = 'ltr';
 
   /** Stream that emits whenever the 'ltr' / 'rtl' state changes. */
-  readonly change = new EventEmitter<void>();
+  readonly change = new EventEmitter<Direction>();
 
   constructor(@Optional() @Inject(DIR_DOCUMENT) _document?: any) {
     if (_document) {