refactor(material/testing): Rename MatButtonHarness "icon" filter to

"iconName"

Author: wildcardalice

goldens/material/button/testing/index.api.md

@@ -17,7 +17,7 @@ export interface ButtonHarnessFilters extends BaseHarnessFilters {
     appearance?: ButtonAppearance;
     buttonType?: ButtonType;
     disabled?: boolean;
-    icon?: string | RegExp;
+    iconName?: string | RegExp;
     text?: string | RegExp;
     variant?: ButtonVariant;
 }

src/material/button/testing/button-harness-filters.ts

@@ -35,5 +35,5 @@ export interface ButtonHarnessFilters extends BaseHarnessFilters {
   buttonType?: ButtonType;
 
   /** Only find instances that contain an icon whose name matches the given value. */
-  icon?: string | RegExp;
+  iconName?: string | RegExp;
 }

src/material/button/testing/button-harness.spec.ts

@@ -116,7 +116,7 @@ describe('MatButtonHarness', () => {
   });
 
   it('should be able to filter buttons containing a named icon', async () => {
-    const favBtn = await loader.getHarness(MatButtonHarness.with({icon: 'favorite'}));
+    const favBtn = await loader.getHarness(MatButtonHarness.with({iconName: 'favorite'}));
 
     expect(await (await favBtn.host()).getAttribute('id')).toBe('favorite-icon');
     expect(await (await favBtn.getHarness(MatIconHarness)).getName()).toBe('favorite');

src/material/button/testing/button-harness.ts

@@ -60,8 +60,8 @@ export class MatButtonHarness extends ContentContainerComponentHarness {
       .addOption('buttonType', options.buttonType, (harness, buttonType) =>
         HarnessPredicate.stringMatches(harness.getType(), buttonType),
       )
-      .addOption('icon', options.icon, (harness, icon) => {
-        return harness.hasHarness(MatIconHarness.with({name: icon}));
+      .addOption('iconName', options.iconName, (harness, iconName) => {
+        return harness.hasHarness(MatIconHarness.with({name: iconName}));
       });
   }